Closed olafurpg closed 2 days ago
The failing Windows check is unrelated to this PR
FAIL |agent| src/chat-response-quality.test.ts [ agent/src/chat-response-quality.test.ts ]
Error: Command failed: pnpm run build:agent
❯ checkExecSyncError ../node:child_process:890:11
❯ Proxy.execSync ../node:child_process:962:15
❯ buildAgentBinary src/TestClient.ts:103:5
101| //
102| // pnpm test agent/src/index.test.ts
mkdir'ing that dir fixed it.
Fixed!
I was surprised that it signed me in automatically, though! It didn't show me an auth screen in my browser:
Good point. I added a confirmation dialog when both --web and --access-token (SRC_ACCESS_TOKEN
) are present.
The Windows CI failure is suspicious because it has failed consistently on every check in this PR and I haven't seen this failure in other CI jobs on main
. I don't understand why it always fails on agent/src/chat-response-quality.test.ts 🤔 will wait with merging until I get all the checks green
I don't understand why it always fails on agent/src/chat-response-quality.test.ts
I haven't reviewed this PR carefully, but just chiming in to say -- we should delete this test! It is fragile, and it's fully superseded by the Chat questions in cody-leaderboard
.
I'll try that and see if it helps. Thank you for chiming in!
Fixes CODY-2633
Previously, users had to set the environment variables
SRC_ACCESS_TOKEN
andSRC_ENDPOINT
to authenticate with the Cody CLI. Now, users can use thecody auth login --web
command instead.The
login --web
command allows users to authenticate through the browser instead. The non-secret configuration settings (username and server endpoint) are stored in a JSON file in the users Cody "config directory", and the access token is stored in the operating systems secret storage (Keychain on macOS, Secret Service API/libsecret on Linux, and Credential Vault on Windows).Implementation note: from past experience, I decided to implement multi-account support from the start. Most casual users don't need this functionality but it's super convenient for internal testing and it's not much more effort compared to only supporting a single account.
Test plan
Manually tested these flows: