search

sourcegraph / cody

AI that knows your entire codebase
https://cody.dev
Apache License 2.0
2.26k stars 215 forks source link

Agent: add stylesheet for jetbrains #4744

Closed abeatrix closed 1 day ago

abeatrix commented 3 days ago

Replace https://github.com/sourcegraph/cody/pull/4709

Initial mapping of the variables of JetBrains to VS code webview.

incremental improvements coming.

Test plan

  1. CODY_DIR=/Users/dpc/projects/cody ./gradlew :runIDE -PforceAgentBuild=true
  2. Open Cody Experimental Chat UX sidebar, right click, Open DevTools
  3. Check that a ton of JetBrains theme variables appear.
  4. Check that the values parse OK
  5. Switch theme in client and expect the webview updated accordingly

High contrast theme:

image

Drucula theme:

image

Light theme:

image

dominiccooney commented 3 days ago

What's the plan here, because you've dropped https://github.com/sourcegraph/cody/commit/95ceb538007527cd26c8d9055b4c56db48a41432 which you need to set the data-ide property, etc.

dominiccooney commented 1 day ago

Thanks for working on this!

Bit of commit message polish would be great: instead of WIP we could say something about incremental improvements coming.

Do you want to land this to keep the diff small and do anything needed for font sizes, sizes, etc. in a follow up?

abeatrix commented 1 day ago

Thanks for working on this!

Bit of commit message polish would be great: instead of WIP we could say something about incremental improvements coming.

Do you want to land this to keep the diff small and do anything needed for font sizes, sizes, etc. in a follow up?

Yea let's do this! Let me update the PR with your feedback and rebase it before I merge, thanks for reviewing!