CLI: Fix npm release - Githubissues

sourcegraph / cody

AI that knows your entire codebase

https://cody.dev

Apache License 2.0

2.26k stars 215 forks source link

CLI: Fix npm release #4749

Closed olafurpg closed 3 days ago

olafurpg commented 3 days ago

Previously, npm install -g @sourcergraph/cody-agent didn't work. This PR fixes the problem

Includes keytar file in Cody cli npm release
Uses peerDependencies instead of depenencies and devDependencies so users don't install transitive dependencies

Test plan

Manually tested by running a local verdaccio registry and installing from there.

github-actions[bot] commented 3 days ago

‼️ Hey @sourcegraph/cody-security, please review this PR carefully as it introduces the usage of an unsafe_ function or abuses PromptString.

olafurpg commented 3 days ago

Re-running an unrelated test failure. This looks similar to the context-quality issue I saw recently

 FAIL  |agent| src/fix.test.ts [ agent/src/fix.test.ts ]
Error: Command failed: pnpm run build:agent
 ❯ checkExecSyncError ../node:child_process:890:11
 ❯ Proxy.execSync ../node:child_process:962:15
 ❯ buildAgentBinary src/TestClient.ts:105:5
    103|     //

Looks like something became more flaky recently in running pnpm build:agent

olafurpg commented 3 days ago

🍿 https://github.com/sourcegraph/cody/actions/runs/9759317330