Closed valerybugakov closed 16 hours ago
@hitesh-1997, I gave it my best shot with manual testing (which is how I found https://github.com/sourcegraph/cody/pull/6171), but this is still a pretty sensitive area without any tests yet (referring to the default renderer). Let me know if you spot anything during your manual testing!
@hitesh-1997, I gave it my best shot with manual testing (which is how I found #6171), but this is still a pretty sensitive area without any tests yet (referring to the default renderer). Let me know if you spot anything during your manual testing!
This makes sense @valerybugakov Played with the PR for sometime, I didn't find anything breaking with manual testing but since we are starting to make more frequent changes, we should definitely prioritize tests, will try to wrap up the diff logic PR from my end so that we can move to testing :)
changes: LineChange
toModifiedLineInfo
, representing individual insertions and deletions in modified lines. This is helpful for troubleshooting purposes, and I plan to use it for the experimental inline renderer implementation that we discussed recently in Slack.Test plan
Manually tested; updated existing diff-utils unit tests and added new ones to cover
LineChange
calculations.