sourcegraph / cody

Type less, code more: Cody is an AI code assistant that uses advanced search and codebase context to help you write and fix code.
https://cody.dev
Apache License 2.0
2.79k stars 302 forks source link

chore(audoedit): simplify diff utils and renderer data structures #6172

Closed valerybugakov closed 16 hours ago

valerybugakov commented 1 day ago

Test plan

Manually tested; updated existing diff-utils unit tests and added new ones to cover LineChange calculations.

valerybugakov commented 1 day ago

@hitesh-1997, I gave it my best shot with manual testing (which is how I found https://github.com/sourcegraph/cody/pull/6171), but this is still a pretty sensitive area without any tests yet (referring to the default renderer). Let me know if you spot anything during your manual testing!

hitesh-1997 commented 1 day ago

@hitesh-1997, I gave it my best shot with manual testing (which is how I found #6171), but this is still a pretty sensitive area without any tests yet (referring to the default renderer). Let me know if you spot anything during your manual testing!

This makes sense @valerybugakov Played with the PR for sometime, I didn't find anything breaking with manual testing but since we are starting to make more frequent changes, we should definitely prioritize tests, will try to wrap up the diff logic PR from my end so that we can move to testing :)