search

sourcegraph / go-diff

Unified diff parser and printer for Go
https://sourcegraph.com/github.com/sourcegraph/go-diff
Other
425 stars 47 forks source link

Add basic support for binary diffs #46

Closed eseliger closed 4 years ago

eseliger commented 4 years ago

This adds support for parsing the cases in ./diff/testdata/sample_binary_inline.diff correctly.

codecov[bot] commented 4 years ago

Codecov Report

Merging #46 into master will increase coverage by 0.18%. The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   28.12%   28.31%   +0.18%     
==========================================
  Files           5        5              
  Lines        1152     1155       +3     
==========================================
+ Hits          324      327       +3     
+ Misses        784      783       -1     
- Partials       44       45       +1
Impacted Files Coverage Δ
diff/parse.go 81.04% <62.50%> (+0.18%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8c3ae63...75d7ce2. Read the comment docs.

eseliger commented 4 years ago

Previously the file paths would be empty strings, now they are properly populated