Closed sofiia-tesliuk closed 4 years ago
Merging #50 into master will increase coverage by
1.17%
. The diff coverage is90.90%
.
@@ Coverage Diff @@
## master #50 +/- ##
==========================================
+ Coverage 28.31% 29.48% +1.17%
==========================================
Files 5 5
Lines 1155 1177 +22
==========================================
+ Hits 327 347 +20
- Misses 783 784 +1
- Partials 45 46 +1
Impacted Files | Coverage Δ | |
---|---|---|
diff/diff.go | 86.48% <ø> (ø) |
|
diff/print.go | 45.67% <60.00%> (+0.94%) |
:arrow_up: |
diff/parse.go | 82.04% <100.00%> (+0.99%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update f935979...29fa046. Read the comment docs.
BTW thank you so much for the great pull request!
Related issue: https://github.com/sourcegraph/go-diff/issues/49 closes #49
There are some changes from planned implementation:
nil
OrigName
field.[2].OrigName: "source_b/file_3.txt
and[2].NewName: ""
will be relevant. Because in case diff file only contains messages about added/deleted files, it is impossible to determine which of the sources is the original one.Then for this file example, the output below for ReadAllFiles() would be expected. my_diff.txt