search

sourcegraph / go-langserver

Go language server to add Go support to editors and other tools that use the Language Server Protocol (LSP)
https://sourcegraph.com
MIT License
1.17k stars 89 forks source link

Option to Disable Hover #312

Closed drgrib closed 6 years ago

drgrib commented 6 years ago

The plug-in doesn't seem to respect global hover settings. I don't need hover and it is really invasive to my coding process, especially when it pops up for the 10th time I fill in fmt.Println to explain to me how the function works. And then continues to follow my cursor and take up a substantial amount of screen real estate as I try to focus on and remember what I was trying to type into the Println.

In short: I want autocomplete from the server, not hover. How do I accomplish this?

keegancsmith commented 6 years ago

the issue is with your client, not go-langserver. IE your client is sending hover requests, but it sounds like you don't want it to.

drgrib commented 6 years ago

@keegancsmith Okay. I'm using VS Code. But I have a feeling they would send me back to go-langserver for requests.

slimsag commented 6 years ago

Yeah, this is a problem with the client. The language server cannot do anything to reject such requests or access your hover settings, I think. I don't think they will defer you back here for this issue if you file it here: https://github.com/Microsoft/vscode-go @ramya-rao-a what do you think?

ramya-rao-a commented 6 years ago

@drgrib Add "editor.parameterHints.enabled": false to your settings.

For future reference, the presence and behavior of an UI element is the responsibility of the editor. The content in these elements is the responsibility of the editor extension. In the case of Go in VS Code, some of these content responsibilities are taken up by the language server

drgrib commented 6 years ago

@ramya-rao-a I'm afraid that does nothing for me. Tried it, restarted the editor, behavior is exactly the same.

Where should I post about this problem? https://github.com/Microsoft/vscode-go?

ramya-rao-a commented 6 years ago

Yes, log an issue at https://github.com/Microsoft/vscode-go. Also include screenshots of what exactly you want to disable. We have different widgets that show up when typing: suggest widget, hover widget, parameter hint/signature help widget

drgrib commented 6 years ago

This actually solved it for me. Found it on StackOverflow:

"editor.parameterHints": false

Can't tell you how many frustrating, crippling moments of trying to edit Go in VS Code this caused me. Relieved to have it stopped.

ramya-rao-a commented 6 years ago

Interesting, in the Insiders build that setting is editor.parameterHints.enabled and that's why I suggested it. But in the stable build, the same is editor.parameterHints. I'll look into that separately.

Thanks for getting back as to what finally fixed it.