search

sourcegraph / go-langserver

Go language server to add Go support to editors and other tools that use the Language Server Protocol (LSP)
https://sourcegraph.com
MIT License
1.17k stars 89 forks source link

Add support for linting #318

Closed ianlopshire closed 5 years ago

ianlopshire commented 6 years ago

This pull requests adds basic support for linting.

ianlopshire commented 6 years ago

Can I get a code review on this?

I am still planning on adding support for a couple other linters, but I will open other pull requests for those.

keegancsmith commented 5 years ago

Sorry, I've been AFK due to public holidays and conferences on my side. I'll take a look now. In future feel free to at mention myself or slimsag.

keegancsmith commented 5 years ago

Apologies, I ran out of time today. It is the top of my TODO list tomorrow to give this a proper review.

nicksnyder commented 5 years ago

Did this close https://github.com/sourcegraph/go-langserver/issues/314?

imjustfly commented 5 years ago

find a unnecessary panic in lint, detail #322