builtin hover docs support

sourcegraph / go-langserver

Go language server to add Go support to editors and other tools that use the Language Server Protocol (LSP)

https://sourcegraph.com

MIT License

1.17k stars 89 forks source link

builtin hover docs support #333

Closed kzh closed 6 years ago

kzh commented 6 years ago

This pull request is to improve documentation preview on hover support for builtin types, functions, and variables. This fixes #174 (Hover doesn't work for builtins).

Todo:

1) add unit tests 2) fix incomplete type/function/variable header (append -> func([]int, int) []int vs.func append([]int, int) []int) 3) heavy refactoring to clean up code

nicksnyder commented 6 years ago

Does this fix https://github.com/sourcegraph/go-langserver/issues/174 ?

If so add "fixed https://github.com/sourcegraph/go-langserver/issues/174" to the PR description

keegancsmith commented 6 years ago

Thanks!