search

sourcegraph / go-langserver

Go language server to add Go support to editors and other tools that use the Language Server Protocol (LSP)
https://sourcegraph.com
MIT License
1.17k stars 89 forks source link

Strip .git suffix from dependencies #364

Closed chrismwendt closed 5 years ago

chrismwendt commented 5 years ago

Some users have import paths that look like example.com/user/repo.git and the repository name on Sourcegraph is example.com/user/repo (without .git).

Prior to this change, go-langserver would attempt to fetch example.com/user/repo.git and get a 404.

After this change, go-langserver will fetch example.com/user/repo instead. This will break when the repository name on Sourcegraph has a .git suffix. @beyang Does that seem acceptable? Alternatively, go-langserver could try the original (with .git) and then fallback to dropping the suffix.

This worked in Sourcegraph 2.x probably because the repository contents were obtained through lsp-proxy and gitserver, rather than the raw API.

beyang commented 5 years ago

Trying and then falling back seems better than stripping the .git suffix altogether (as the latter might cause further unanticipated failures).

chrismwendt commented 5 years ago

Switched to trying then falling back.