sourcegraph / go-selenium

Selenium WebDriver client for Go
https://sourcegraph.com/github.com/sourcegraph/go-selenium
Other
367 stars 73 forks source link

Test for error handling #25

Closed keegancsmith closed 8 years ago

keegancsmith commented 8 years ago

Also updated the example test so it passes.

This PR originally tried to improve on our error handling, but I'm leaving that out for now and just including the related fixes.

slimsag commented 8 years ago

LGTM -- but CI looks borked due to something unrelated(?)

keegancsmith commented 8 years ago

@slimsag I can't actually view the CI for this for some reason. But I would assume it is unrelated. I ran all the tests locally. If you think it is unrelated, then I'll merge. Is that cool?

slimsag commented 8 years ago

Yeah -- no clue, it's gotta be unrelated

image

let's ship!