sourcegraph / go-selenium

Selenium WebDriver client for Go
https://sourcegraph.com/github.com/sourcegraph/go-selenium
Other
367 stars 73 forks source link

Impose read limit for large content/screenshot etc. #28

Open shicky opened 8 years ago

shicky commented 8 years ago

It would be nice to have an option to set read limit for large file size.

func (wd *remoteWebDriver) execute(method, url string, data []byte) ([]byte, error) {

    // omitted ...

    buf, err := ioutil.ReadAll(res.Body)
    if err != nil {
        return nil, err
    }

    // omitted ...

}

to

func (wd *remoteWebDriver) execute(method, url string, data []byte) ([]byte, error) {

    // omitted ...

    limit := 1 << 20 // 1MB limit
    buf, err := ioutil.ReadAll( io.LimitReader(r.Body, limit) )
    if err != nil {
        return nil, err
    }

    // omitted ...

}