search

sourcegraph / go-sourcegraph

https://sourcegraph.com/github.com/sourcegraph/go-sourcegraph
MIT License
42 stars 9 forks source link

moved DefFormatStrings to srclib/graph #50

Closed neelance closed 9 years ago

gbbr commented 9 years ago

Is this fixing any specific bug? If not, should we be making breaking changes so close to release? Also, has the srclib change already been made? If it has, does this PR depend on another PR?

neelance commented 9 years ago

Yeah, the other one is https://github.com/sourcegraph/srclib/pull/178. This is necessary towards the goal of getting rid of the def formatters and thus the srclib toolchain dependencies. DefFormatStrings is not used very often, so the change has a low impact.

sqs commented 9 years ago

lgtm

dmitshur commented 9 years ago

LGTM.