Add UpdateResult to UpdateEverything method.

[dmitshur]

This is an early draft of a sample implementation for proposal #79. It's very easy to refactor and change it.

• Currently implemented in gitcmd backend only, the new functionality parses the output of git remote update operation and returns it to the caller.
• This is a breaking API change because it adds an extra return parameter to a method of RemoteUpdater interface.
• Add tests for the parser.

Resolves #79.

[slimsag]

@shurcooL everything you have said makes sense. Sorry for my confusion! This looks good to me. If you feel confident about the change, feel free to merge. If not, feel free to ping another for additional review here.

[dmitshur]

@shurcooL everything you have said makes sense. Sorry for my confusion! This looks good to me.

Great, and no problem!

If you feel confident about the change, feel free to merge. If not, feel free to ping another for additional review here.

I'm kinda wearing an open-source contributor hat with this PR, and if possible, I'd rather stick to that for the rest of the process. Just learning about what the experience would be like. If it's not possible or takes too long that way, then I'll switch to my project owner hat and do the rest of the work needed to get this merged (and update our dependencies to new API, etc.). :)

[dmitshur]

I've addressed some review comments with the last 2 commits, PTAL.

[dmitshur]

Friendly ping.

[slimsag]

Sorry for the delays here. I've given this a second more extensive review just now, as it seems I'll be the only reviewer.

Please address adding TODO prefixes to the lack-of-implementation comments, after which I'll feel confident in merging this change.

[dmitshur]

After discussion in #79, there's been a change done in f63f96a to the interface:

@@ -23,8 +23,10 @@ type HTTPSConfig struct {
 type RemoteUpdater interface {
    // UpdateEverything updates all branches, tags, etc., to match the
    // default remote repository. The implementation is VCS-dependent.
-   // If supported by the implementation, results of update will be returned.
-   UpdateEverything(RemoteOpts) (UpdateResult, error)
+   //
+   // If supported by the implementation, parsed results of update will be returned,
+   // otherwise it'll be nil.
+   UpdateEverything(RemoteOpts) (*UpdateResult, error)
 }

 // UpdateResult is the result of parsing output of the remote update operation.

Needs a final review and this can be ready to merge.

[beyang]

LGTM

[dmitshur]

Great, I'll merge this soon when I have a little more bandwidth to update the dependents.

Unless someone else is blocking on this, then we can merge sooner.

[slimsag]

I'll be merging this as part of https://src.sourcegraph.com/sourcegraph/.changes/366

[dmitshur]

Woohoo, thanks!