sourcegraph / go-vcs

manipulate and inspect VCS repositories in Go
https://sourcegraph.com/sourcegraph/go-vcs
Other
79 stars 20 forks source link

cmd/go-vcs: Remove deprecated dependency, improve consistency. #97

Closed dmitshur closed 8 years ago

dmitshur commented 8 years ago

Remove deprecated "github.com/shurcooL/go/vcs" dependency. That package has been significantly cleaned up and moved to "github.com/shurcooL/vcsstate". In the process, the tiny set of functionality (determining the type of a repository in a given directory) was removed since it's available elsewhere (golang.org/x/tools/go/vcs.FromDir) for most users.

Use a simplified version of golang.org/x/tools/go/vcs.FromDir to determine type of repository.

Expand coverage of dynamic repository type discovery to all methods rather than just a select few (that were added/modified after a certain date).

neelance commented 8 years ago

LGTM