search

sourcegraph / handbook

📘 The Sourcegraph handbook
https://handbook.sourcegraph.com
Apache License 2.0
151 stars 112 forks source link

Update locations page to be auto-generated #1745

Open marybelzer opened 2 years ago

marybelzer commented 2 years ago

Slack thread for context.

The locations page in the Handbook is much loved, but cumbersome to maintain and as such is quite out of date.

Input from that slack thread:

I think most of the concerns you listed could be addressed by moving location into an alternate representation similar to what we did with the org chart. We could convert the team page to be generated from a YAML file with an optional location field. I don't think the team page as a whole is intended to be a source of truth anyways, since not all teammates are listed. And then removing a teammate is just deleting a YAML block.

Ideally, we would generate the locations page + map from the information listed on the team page. See here for a proof of concept.

StefanAvra commented 1 year ago

I was browsing the team locations page and saw that the map view is broken. I guess the issue is caused by this trailing comma in the geojson: https://github.com/sourcegraph/handbook/blob/1e7a3ebe035ff195baca24b071b5155c996cb2be/content/team/locations.geojson#L912C11-L912C11