sourcegraph / javascript-typescript-langserver

JavaScript and TypeScript code intelligence through the Language Server Protocol

https://sourcegraph.com

Apache License 2.0

793 stars 72 forks source link

fix(deps): move commitlint packages to devDependencies #553

Closed ybiquitous closed 5 years ago

ybiquitous commented 5 years ago

commitlint ~~and chai~~ packages seem to be used only on development.

commitlint: used on pre commit
~~chai: used on test~~

This PR removes these extra dependencies from runtime dependencies.

codecov-io commented 5 years ago

Codecov Report

Merging #553 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #553   +/-   ##
=======================================
  Coverage   83.09%   83.09%           
=======================================
  Files          15       15           
  Lines        2058     2058           
  Branches      423      489   +66     
=======================================
  Hits         1710     1710           
  Misses        346      346           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a7ec319...42c859d. Read the comment docs.

ybiquitous commented 5 years ago

Thanks for your review! I rewrote the commit, the PR title & message.

ybiquitous commented 5 years ago

I have a question. Is there no need to include also mocha & sinon into dependencies?

felixfbecker commented 5 years ago

I guess yes

sourcegraph-bot commented 5 years ago

:tada: This PR is included in version 2.11.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

ybiquitous commented 5 years ago

Thank you!