search

sourcegraph / javascript-typescript-langserver

JavaScript and TypeScript code intelligence through the Language Server Protocol
https://sourcegraph.com
Apache License 2.0
792 stars 72 forks source link

fix(deps): move chai and chai-as-promised to dev-dependencies #571

Closed rhysd closed 5 years ago

rhysd commented 5 years ago

While checking npm list -g, I noticed assertion libraries for unit tests were installed on my local. They should be in dev-dependencies so I moved them.

codecov-io commented 5 years ago

Codecov Report

Merging #571 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #571   +/-   ##
=======================================
  Coverage   83.09%   83.09%           
=======================================
  Files          15       15           
  Lines        2058     2058           
  Branches      423      423           
=======================================
  Hits         1710     1710           
  Misses        346      346           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a6c1519...431b805. Read the comment docs.

felixfbecker commented 5 years ago

The test suite is published to npm and can be used by extensions of the language server, so we need to have these as true dependencies.