search

sourcegraph / javascript-typescript-langserver

JavaScript and TypeScript code intelligence through the Language Server Protocol
https://sourcegraph.com
Apache License 2.0
793 stars 72 forks source link

Completion not filtering/sorting by prefix #630

Open brainoutsource opened 5 years ago

brainoutsource commented 5 years ago

Hello! I'm working on a tool which uses javascript-typescript-langserver among other LSPs.

Diagnostics work fine, but I'm having trouble (or am I?) with the way completion works. Consider the example:

1) I invoke completion (| is the position of the cursor I send with CompletionParams.Position):

document.body.|textContent = user;

and get all kinds of relevant stuff, starting with accessKey, and including the textContent.

2) Now I invoke the completion here:

document.body.tex|tContent = user;

and I get the very same result, not filtered or sorted by the tex prefix.

Is it an expected behaviour? Is it LSP client's job to sort/filter the completion suggestions? Thank you!

Btw, theia-ide/typescript-language-server/ displays the same behaviour.

garyo commented 4 years ago

I'm having the same issue. Any news on this?

hcnode commented 4 years ago

Any update on this issue? this seems obviously even I use the vs plugin based on this lib, this issue still happen.