search

sourcegraph / javascript-typescript-langserver

JavaScript and TypeScript code intelligence through the Language Server Protocol
https://sourcegraph.com
Apache License 2.0
793 stars 72 forks source link

fix(logging): do not use JSON.stringify to Error object #666

Open Milly opened 4 years ago

Milly commented 4 years ago

the result of JSON.stringify(new Error('msg')) is {}. pass the Error object to logger as it is.

codecov-io commented 4 years ago

Codecov Report

Merging #666 into master will increase coverage by 0.18%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #666      +/-   ##
==========================================
+ Coverage   82.40%   82.59%   +0.18%     
==========================================
  Files          15       15              
  Lines        2126     2126              
  Branches      509      448      -61     
==========================================
+ Hits         1752     1756       +4     
+ Misses        364      360       -4     
  Partials       10       10
Impacted Files Coverage Δ
src/plugins.ts 90.90% <100.00%> (+6.06%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fd893d2...5a663b4. Read the comment docs.