search

sourcegraph / jsonrpc2

Package jsonrpc2 provides a client and server implementation of JSON-RPC 2.0 (http://www.jsonrpc.org/specification)
MIT License
196 stars 62 forks source link

fix some golangci-lint, revive linter warnings #25

Closed s3rj1k closed 5 years ago

s3rj1k commented 5 years ago

This PR fixes some issues that were reported by golangci and revive linters.

Signed-off-by: s3rj1k evasive.gyron@gmail.com

s3rj1k commented 5 years ago

@sqs would be nice for this to be merged so some more work could be done with code

sqs commented 5 years ago

Thanks! Could you please remove instead of commenting out code (I saw 2 instances of this)? Then I will approve and merge.

sqs commented 5 years ago

I just made those changes and pushed them to your branch. Will merge when CI is green.

s3rj1k commented 5 years ago

@sqs super, as a bonus, you did a go.mod. thanks )