search

sourcegraph / jsonrpc2

Package jsonrpc2 provides a client and server implementation of JSON-RPC 2.0 (http://www.jsonrpc.org/specification)
MIT License
190 stars 62 forks source link

[BUG] OnRecv() func logging, wrong case check? #33

Closed s3rj1k closed 4 years ago

s3rj1k commented 4 years ago

Shouldn't this 

case req != nil && resp == nil:

be like this

case req != nil:

for logging all request queries?

s3rj1k commented 4 years ago

@unknwon any thoughts on this?

unknwon commented 4 years ago

TBH... I have no idea.

s3rj1k commented 4 years ago

@unknwon https://github.com/sourcegraph/jsonrpc2/pull/34/files some minor log issues

s3rj1k commented 4 years ago

PR merged, thanks, closing this.