sourcegraph / learn

Sourcegraph Learn: an educational hub to support all developers
https://learn.sourcegraph.com
Apache License 2.0
18 stars 34 forks source link

Series dropdown menu #382

Closed katjuell closed 2 years ago

katjuell commented 2 years ago

What should this PR do?

Resolves DEVED-265 by updating our collection list to be a dropdown menu with toggle.

Why are we making this change?

We want to improve navigation within the site and on all pages.

What are the acceptance criteria?

How should this PR be tested?

Pull request process

Reviewers:

  1. Test functionality using the criteria above.
  2. Offer tips for efficiency, feedback on best practices, and possible alternative approaches and things that may not have been considered.
  3. For shorter, "quick" PRs, use your best judgement on #​2.
  4. Use a collaborative approach and provide resources and/or context where appropriate.
  5. Provide screenshots/grabs where appropriate to show findings during review.

Reviewees:

  1. Prefer incremental and appropriately-scoped changes.
  2. Leave a comment on things you want explicit feedback on.
  3. Respond clearly to comments and questions.
netlify[bot] commented 2 years ago

✔️ Deploy Preview for sourcegraph-learn ready!

🔨 Explore the source changes: 9ca66eed653cff4e491ef039b5ccde1272a54810

🔍 Inspect the deploy log: https://app.netlify.com/sites/sourcegraph-learn/deploys/61a532114952d80007623eaa

😎 Browse the preview: https://deploy-preview-382--sourcegraph-learn.netlify.app

katjuell commented 2 years ago
Screen Shot 2021-11-29 at 1 27 07 PM Screen Shot 2021-11-29 at 1 27 14 PM Screen Shot 2021-11-29 at 1 27 25 PM Screen Shot 2021-11-29 at 1 27 33 PM Screen Shot 2021-11-29 at 1 27 50 PM
katjuell commented 2 years ago

Some questions I have for you @ltagliaferri:

ltagliaferri commented 2 years ago

Feel good about the toggle icon, I think the border on the dropdown modal can be lighter.

katjuell commented 2 years ago

Sweet — thanks!