sourcegraph / learn

Sourcegraph Learn: an educational hub to support all developers
https://learn.sourcegraph.com
Apache License 2.0
18 stars 34 forks source link

Add right padding for code elements in Highlighter #384

Closed katjuell closed 2 years ago

katjuell commented 2 years ago

What should this PR do?

Resolves DEVED-281 by adding a small amount of padding to code elements in the Highlighter component, to prevent italicized tokens from being cut off.

Why are we making this change?

What are the acceptance criteria?

How should this PR be tested?

Pull request process

Reviewers:

  1. Test functionality using the criteria above.
  2. Offer tips for efficiency, feedback on best practices, and possible alternative approaches and things that may not have been considered.
  3. For shorter, "quick" PRs, use your best judgement on #​2.
  4. Use a collaborative approach and provide resources and/or context where appropriate.
  5. Provide screenshots/grabs where appropriate to show findings during review.

Reviewees:

  1. Prefer incremental and appropriately-scoped changes.
  2. Leave a comment on things you want explicit feedback on.
  3. Respond clearly to comments and questions.
katjuell commented 2 years ago
Screen Shot 2021-11-30 at 10 23 25 AM
netlify[bot] commented 2 years ago

✔️ Deploy Preview for sourcegraph-learn ready!

🔨 Explore the source changes: 166ec6e0a5092633213e1e0f2b6361d1c278bbbc

🔍 Inspect the deploy log: https://app.netlify.com/sites/sourcegraph-learn/deploys/61a6432311cf040007b98a22

😎 Browse the preview: https://deploy-preview-384--sourcegraph-learn.netlify.app