sourcegraph / learn

Sourcegraph Learn: an educational hub to support all developers
https://learn.sourcegraph.com
Apache License 2.0
18 stars 34 forks source link

[Feature Request] Use a single toggle for light and dark theme instead of two separate buttons #490

Open lourdesr opened 2 years ago

lourdesr commented 2 years ago

Is your feature request related to a problem? Please describe. My request isn't a problem really, it's just a small UI suggestion to make it look more cleaner. I could definitely be wrong but I just thought I'd put it out here and ask the team's opinions.

Screen Shot 2022-05-26 at 10 11 03 AM

Describe the solution you'd like My solution would just check if the theme is dark, and toggle the UI based on it. I have the code locally and it works. Need guidance on branching and branch names then I can send a PR.

Screen Shot 2022-05-26 at 10 11 09 AM Screen Shot 2022-05-26 at 10 11 15 AM

Describe alternatives you've considered None for now. Since this is a tiny feature, more like a nice-to-have, I haven't really considered other alternatives.

Additional context I've used VueJS only till now. I'm new to React and trying to learn, so I'm not entirely sure if what I'm doing is the right thing, so please advice. Really appreciate it and thanks for taking a look at this.