sourcegraph / learn

Sourcegraph Learn: an educational hub to support all developers
https://learn.sourcegraph.com
Apache License 2.0
18 stars 34 forks source link

Update repo predicate examples in cheat sheet #507

Closed tbliu98 closed 2 years ago

tbliu98 commented 2 years ago

Replace the repo:contains examples with repo:has in cheat sheet. Query completion now suggests predicates using repo:has syntax so the cheat sheet should align.

Type of change

Documentation update

What should this PR do?

Update search cheat sheet to align with the current user-facing state of predicate syntax.

Why are we making this change?

Predicate syntax has changed, making some examples on this page invalid. Query completion now suggests predicates using repo:has syntax so the cheat sheet should align.

What are the acceptance criteria?

How should this PR be tested?

Pull request process

Reviewers:

  1. Test functionality using the criteria above.
  2. Offer tips for efficiency, feedback on best practices, and possible alternative approaches and things that may not have been considered.
  3. For shorter, "quick" PRs, use your best judgement on #​2.
  4. Use a collaborative approach and provide resources and/or context where appropriate.
  5. Provide screenshots/grabs where appropriate to show findings during review.

Reviewees:

  1. Prefer incremental and appropriately-scoped changes.
  2. Leave a comment on things you want explicit feedback on.
  3. Respond clearly to comments and questions.
netlify[bot] commented 2 years ago

Deploy Preview for sourcegraph-learn ready!

Name Link
Latest commit c7a17e26d9a0d829ee7180caeba8ccff0ec58487
Latest deploy log https://app.netlify.com/sites/sourcegraph-learn/deploys/630f74668a2d0e00095aaf3d
Deploy Preview https://deploy-preview-507--sourcegraph-learn.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

tbliu98 commented 2 years ago

I do not know who should review this, so I just tagged the people suggested by GitHub as well as search product platform people -- if you know a more appropriate reviewer please tag them