search

sourcegraph / lsif-clang

Language Server Indexing Format (LSIF) generator for C, C++ and Objective C
https://lsif.dev/
35 stars 8 forks source link

Support newer version of clang? #62

Closed bhush9 closed 2 years ago

bhush9 commented 2 years ago

Hello!

Is there any plan to add support for newer version of clang? In some distributions only packages for newer clang are available and that makes it hard to build this.

Thanks.

varungandhi-src commented 2 years ago

Could you expand on what the issue is (e.g. which distro, which Clang version, what the build error is)? Normally, Clang releases are largely backwards compatible, and the code here should not be using the libclang that is installed through the OS package manager.

jlisee commented 2 years ago

In an effort to get a more stable version of the tool jlisee/llvm-13.0.1-upgrade-v2. The main changes are in this commit jlisee/lsif-clang@df04f9e0d0bac389ea83fea309dc56c8fcb152dd, GitHub is not smart enough to only show merge changes but it just maintained to 2 small changes to the clangd source).

In the build above with Clang 13 and one issue I found is that CMakeLists don't specify which exact version of LLVM should be used. The are not always compatible and fixing the version is way to make sure the build works.

varungandhi-src commented 2 years ago

Closing in favor of https://github.com/sourcegraph/lsif-clang/issues/89 since that issue has more details on the subtasks of getting this done.