tjdevries
commented
3 years ago Hi!
I'm not sure exactly what you're referencing in the first link. I don't think these executions were run on the same machine, so I'm not sure they make sense (and I'm not sure where the 8.20 minutes execution came from, since we've done a lot to try and improve performance of lsif-go potentially since that time).
I will try and update the benchmark documents to try and make it more obvious what is happening there.
Hi, I got quite confused when see these two data:
In https://docs.sourcegraph.com/code_intelligence/explanations/precise_code_intelligence, the index time on aws-sdk-go is 8.20m
, while in https://github.com/sourcegraph/lsif-go/blob/master/BENCHMARK.md, the index time on monorepo-1 is 23.8s.
Per my understanding.. in these two table, "index time" both indicate processing time of the indexer(which is lisf-go). According to script that generates source code, monorepo-1 should contain an extra copy of services dir, but these two data seem far too different.
Please let me know if I got it incorrect. Many thanks, -John