sourcegraph / lsif-go

Language Server Indexing Format (LSIF) generator for Go
https://lsif.dev/
MIT License
116 stars 20 forks source link

Do not disable cgo (rm CGO_ENABLED=0) #233

Closed chrismwendt closed 2 years ago

chrismwendt commented 2 years ago

You can disable it with env CGO_ENABLED=0 lsif-go if necessary.

Fixes https://github.com/sourcegraph/sourcegraph/issues/33285

Might fix https://github.com/sourcegraph/sourcegraph/pull/30307#issuecomment-1041917665. I was unable to repro the error, but I was able to determine that binding.go is now included in the output whereas before this change it wasn't.

Might fix https://github.com/sourcegraph/lsif-go/issues/227 for the same reason.

I didn't notice any negative consequences of this change:

varungandhi-src commented 2 years ago

Could you elaborate on how this fixes https://github.com/sourcegraph/sourcegraph/issues/33285?