search

sourcegraph / lsif-go

Language Server Indexing Format (LSIF) generator for Go
https://lsif.dev/
MIT License
116 stars 20 forks source link

Disable animation by default #256

Closed olafurpg closed 2 years ago

olafurpg commented 2 years ago

Animation currently breaks manual indexing of sourcegraph/sourcegraph because it blocks a prompt from git about trusting a fingerprint. Until we figure out a way to enable stdin together with animation, it's best to disable animation so that customers don't experienc buggy behavior out of the box.

Test plan

I built the binary locally and manually verified that I was able to index sourcegraph/sourcegraph with the command lsif-go (no flags). Before this commit, I needed to manually add --no-animation, which is not obvious if you're a customer and trying to index a codebase.

olafurpg commented 2 years ago

Closing this PR because it's from my fork. Will open a new PR from the main repo