search

sourcegraph / lsp-adapter

lsp-adapter provides a proxy which adapts Sourcegraph LSP requests to vanilla LSP requests
MIT License
29 stars 8 forks source link

Remove manual installation instructions and refer to about.sourcegraph.com/docs #66

Closed chrismwendt closed 6 years ago

chrismwendt commented 6 years ago

This removes all the manual installation instructions from each individual language's README and instead links to http://about.sourcegraph.com/docs/code-intelligence/preview-languages now that the manual steps are no longer necessary.

Fixes https://github.com/sourcegraph/lsp-adapter/issues/59 Fixes https://github.com/sourcegraph/sourcegraph/issues/11105 because the docs page will state the caveats

keegancsmith commented 6 years ago

http://about.sourcegraph.com/docs/code-intelligence/preview-languages link does not work for me.

chrismwendt commented 6 years ago

Oh right, I renamed it to experimental languages.

On Thu, May 17, 2018, 1:43 AM Keegan Carruthers-Smith < notifications@github.com> wrote:

http://about.sourcegraph.com/docs/code-intelligence/preview-languages link does not work for me.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sourcegraph/lsp-adapter/pull/66#issuecomment-389791718, or mute the thread https://github.com/notifications/unsubscribe-auth/ABUshXFfMkSviBWgVmHdpe-L6vl-xON4ks5tzTgogaJpZM4UCaeD .

keegancsmith commented 6 years ago

your links are also http. Should be https.

nicksnyder commented 6 years ago

We want to emphasize open source language servers so I would suggest naming the link “experimental-language-servers”

nicksnyder commented 6 years ago

In your pr description you should get in the habit of pasting the full link to the issue so cross repository issues work

chrismwendt commented 6 years ago

Thanks for the review 🙇 I'll merge this in after the links get renamed to "experimental-language-servers" in https://github.com/sourcegraph/website/pull/295