sourcegraph / openctx

See contextual info about code from your dev tools, in your editor, code review, and anywhere else you read code.
https://openctx.org
Apache License 2.0
145 stars 16 forks source link

Clicking provider-links does not work in VSCode #46

Open Logonz opened 4 months ago

Logonz commented 4 months ago

I understand that this is very much a VIP and experimental but wanted to report that a simple provider-links does not work when clicking in the editor. Using the icon at the top of the screen to show all matches in a dropdown works however.

        {
          "title": "🐘 $<table> table (PostgreSQL console)",
          "url": "https://example.com/postgresql?table=$<table|queryEscape>",
          "description": "View table schema and data...",
          "path": "**",
          "pattern": "(FROM|UPDATE|INSERT INTO|DELETE FROM|ALTER TABLE) (?<table>\\w+)"
        },

The example you provided works to show it in the editor but clicking it produces nothing from what i can see.

sqs commented 4 months ago

Clicking it should take you to the example.com URL. Is it that clicking it did not take you there, or that it's confusing because an example.com URL is not actually a helpful link for that? If the latter, then that should be resolved when we add some more non-example providers. We've got a bunch more in progress in the last few weeks and will soon be able to show off exclusively providers that are actually useful.

keegancsmith commented 4 months ago

@sqs this is probably the vscode-uri not correctly handling URL query escaping rearing its head.

Logonz commented 4 months ago

With the new version this seems to be fixed for me.