Prefer canonical references for using-imported decalrations

Say I have code like the following:

namespace x {
  struct S {};
}
namespace y {
  using x::S; // equivalent to `using S = x::S`
  void f() {
    S{}; y::S{};
  }
}

The question is what should Go to Definition behave like when:

Trying GTD from S{}
Trying GTD from y::S{}

In both cases, GTD in VS Code/clangd shows both the struct and using lines. In CLion, both go directly to the struct line.

As it stands, scip-clang will emit a reference to y::S and take one to the using line directly. While this is technically correct, attempting Go to Definition to the using line doesn't do anything (even though there is a reference to x::S). Example in LLVM:

For now, I think we should just emit a reference to the canonical declaration directly. If we add support for some kind of alias role, then we can also emit a definition for the alias declaration.

sourcegraph / scip-clang

Prefer canonical references for using-imported decalrations #320