search

sourcegraph / scip-clang

Apache License 2.0
55 stars 7 forks source link

ProjectRoot format #473

Closed qaqland closed 7 months ago

qaqland commented 7 months ago

https://github.com/sourcegraph/scip-clang/blob/b7ecba1fe978d24b1ea83ddebaf22dcee71e48c5/indexer/Driver.cc#L1049

maybe it should be file://<path>, thus become compatible with "standard parsing" like go?

https://go.dev/play/p/nUzyrTnqeMX

reference:

https://github.com/sourcegraph/scip/issues/98

varungandhi-src commented 7 months ago

You're right, it should be file://

varungandhi-src commented 7 months ago

Opened PR here: https://github.com/sourcegraph/scip-clang/pull/474

qaqland commented 7 months ago

thx