search

sourcegraph / scip-dotnet

SCIP indexer for the C# programming language. Built with the Roslyn .NET compiler
Apache License 2.0
12 stars 2 forks source link

Revert changes that make parameters local #39

Closed sagi1623 closed 1 year ago

sagi1623 commented 1 year ago

As it can be seen in this comment, I realised making Parameters local was a mistake, as Named arguments is a thing for both C# and VbNet. There are actually test cases in the Expressions file for both C# and VbNet, that I have glimpsed over because of the sheer amount of changes the PR introduced.

Sorry once more for the mistake.

sagi1623 commented 1 year ago

@olafurpg,

I have made a mistake in the previous PR! Sorry for that. This one is here to revert part of the changes I have done there. I promise, next time I will think twice before doing changes.

sagi1623 commented 1 year ago

It is completely my fault for missing the named argument usage. The problem is that even though I enjoy working on this a lot, I usually don't have the time to do so during the day. And after a full workday around 10 PM in the evening it is easy for me to miss things. I promise I will be more careful in the future.

olafurpg commented 1 year ago

@sagi1623 no worries at all!