Implement new scip `SymbolInformation` fields - Githubissues

sourcegraph / scip-java

SCIP Code Intelligence Protocol generator for Java

https://sourcegraph.github.io/scip-java/

Apache License 2.0

71 stars 28 forks source link

Implement new scip `SymbolInformation` fields #666

Open nicolas-guichard opened 11 months ago

nicolas-guichard commented 11 months ago

sourcegraph/scip/issues/154 added support for a number of new fields in SCIP's SymbolInformation:

kind
display_name
signature_documentation
enclosing_symbol (what was originally proposed as owner or parent in the linked issue)

On the Java side the sematicdb data already contains the kind (and properties, eg to build an AbstractMethod), but it does not on the Kotlin side.

For both Java and Kotlin:

the semantidb data provides display_name
the signature_documentation is already the first line of the documentation
semanticdb does not specify the owner/enclosing_symbol for locals anymore, although there is already discussion about adding it back in scalameta/scalameta/issues/1540

varungandhi-src commented 11 months ago

We're not implementing new enhancement/feature requests at the moment. If you'd like to submit a PR, we can review PRs on a best-effort basis.