Fix bugs in Gradle integration - Githubissues

sourcegraph / scip-java

SCIP Code Intelligence Protocol generator for Java

https://sourcegraph.github.io/scip-java/

Apache License 2.0

66 stars 26 forks source link

Fix bugs in Gradle integration #684

Closed keynmol closed 3 months ago

keynmol commented 3 months ago

Fix two bugs in Gradle plugin.

Don't add plugin parameters multiple times - javac seems to consider that an error

> javac -classpath (cs fetch com.sourcegraph:semanticdb-javac:0.9.9) HelloWorld.java "-Xplugin:semanticdb -targetroot:. -sourceroot:." -Xplugin:semanticdb
error: plug-in not found: semanticdb
1 error

> javac -classpath (cs fetch com.sourcegraph:semanticdb-javac:0.9.9) HelloWorld.java "-Xplugin:semanticdb -targetroot:. -sourceroot:."
# finishes successfully

Anticipate "main" source set being absent and handle that gracefully

Test plan

Reproducing both failures seems difficult as I've only spotted them while working on indexing spring codebase.