search

sourcegraph / scip-java

SCIP Code Intelligence Protocol generator for Java
https://sourcegraph.github.io/scip-java/
Apache License 2.0
66 stars 26 forks source link

feat(semanticdsb-scip): map and add SymbolInformation.Kind to scip output #703

Closed JamyDev closed 1 month ago

JamyDev commented 1 month ago

This change adds the SymbolInformation.Kind property to DocumentSymbols. The following changes were required to make this work:

  1. Updated the SCIP proto to the latest version from sourcegraph/scip (keeping the package the same to avoid a bunch of refactoring)
  2. Added a mapper to go from SemanticDb Kind to Scip Kind and called it during the SymbolInformation builder.

Test plan

There's no real way to validate the DocumentSymbols using the snapshot tests. Any recommendations for how to test this properly are appreciated!

JamyDev commented 1 month ago

I see that this is a duplicate of #677, will close if favor of that one.