`self` considerations - Githubissues

sourcegraph / scip-python

SCIP indexer for Python

Other

55 stars 25 forks source link

Closed tjdevries closed 2 years ago

tjdevries commented 2 years ago

Go-to type definition should take you to the class?
What should goto definition do?
What should find references do? Should it show for all references of the same self (i.e. for this class) or just the one for that function?

olafurpg commented 2 years ago

I hit on the case where a self.style variable in the Textualize/rich repo has 0 definitions so the popover is search-based

CleanShot 2022-05-26 at 12 58 30@2x

My expectation is that the definition would be the first occurrence in an assignment position (self.style = ...).

tjdevries commented 2 years ago