tjdevries
commented
2 years ago The new branch name for the upstream of pyright is pyright-mirror that we have in this repo now (so you can see the state of whatever Pyright would be). Additionally, you can look at a diff (via sourcegraph if you'd like) or create a PR (but just don't submit haha) with pyright-mirror as the base, and then scip as the new repo. That should show all the changes we have.
In general, I'm trying quite hard not to change anything in the pyright libraries themselves (except occasionally making some private method public if I need it, but mostly I've found ways to avoid doing that as well), so the bug is probably with scip-python :laughing: . I talk a little bit more about it here: https://github.com/sourcegraph/scip-python#to-compare-upstream-from-pyright
Does that answer everything you were hoping for in this repo? I just did another pull of pyright today, since I'm hoping to bump the version quite soon and do a new release (with a lot of fixes and improvements)
jlisee
It would be awesome if you could keep the
mainbranch thatscip-pythonis based off in repository for easy comparison. I am very curious to know how you are diverging from Pyright. As of this comment I think it's fd98a8a2b964056f7afc616896735689c7cba421 so this link provides the divergence: https://github.com/sourcegraph/scip-python/compare/fd98a8a2b964056f7afc616896735689c7cba421...scip and shows only very minor changes to:My main use case is to use this as a project health/bug check tool. For example if
scip-pythonis confused about something it could be:Pyrightscip-pythonscip-pythonforkThis branch pointer makes that clear.