sourcegraph / scip-typescript

SCIP indexer for TypeScript and JavaScript
Apache License 2.0
46 stars 17 forks source link

Add -- for passing through flags to tsc #92

Open varungandhi-src opened 2 years ago

varungandhi-src commented 2 years ago

If you have an invocation like:

lsif-typescript index <args> -- <other-args>

We should pass through <other-args> to tsc and consume <args> within lsif-typescript.

olafurpg commented 2 years ago

I was going to implement this assuming it was an easy fix but commander merges arguments after -- with positional arguments. We can work around it by manually parsing out command.args (which includes the unparsed list of arguments) but decided to pause since it's unclear in what situations we need this functionality.