sourcegraph / scip

SCIP Code Intelligence Protocol
Apache License 2.0
231 stars 32 forks source link

Clarify usage of IdentifierAttribute and add IdentifierProperty for fields/properties #237

Open varungandhi-src opened 2 months ago

varungandhi-src commented 2 months ago

It looks like a bunch of queries in our highlighting logic in the Sourcegraph monorepo are misusing IdentifierAttribute for marking properties, which are syntactically very different from __attribute__ in C or similar. We should add IdentifierProperty first, and clarify the docs.