Closed kritzcreek closed 4 days ago
We could add checks to
scip lint
Sure, that'd be great.
Sure, that'd be great.
Allright, I think that should work. PTAL
Noticed one more difference between the spec and scip-clang
while writing some benchmarks. scip-clang
will generate descriptors like my_func().
, while the spec does not make the disambiguator in the parenthesis optional.
Spec issue, or scip-clang issue?
Noticed one more difference between the spec and scip-clang while writing some benchmarks. scip-clang will generate descriptors like my_func()., while the spec does not make the disambiguator in the parenthesis optional.
Hmm, I don't see why the disambiguator should be forced to be non-empty -- the rationale for having the disambiguator is that different disambiguator values can correspond to different method overloads (there is no further sub-structure inside it). An empty string is just another string, which is different from other non-empty strings. Unless someone has a compelling reason otherwise, I think we should allow the disambiguator to be empty.
Unless someone has a compelling reason otherwise, I think we should allow the disambiguator to be empty.
@olafurpg @keynmol Thoughts?
+1 to allowing empty disambiguators
Unfortunately I can not get the "build process" to work on my local machine.
Test plan
Added checks to the
lint
command for checking canonical identifiers and that parsing succeeds