sourcegraph / scip

SCIP Code Intelligence Protocol
Apache License 2.0
232 stars 32 forks source link

Doc comments for generated TypeScript bindings #39

Open varungandhi-src opened 2 years ago

varungandhi-src commented 2 years ago

I noticed this weirdness after updating the doc comments and not noticing any change in the generated TypeScript bindings. https://github.com/sourcegraph/scip/pull/37/commits/96b8a17238480fd903eb2c505a505aca91907932

https://github.com/sourcegraph/scip/blob/e3f61b1d63533749fd2c0401b9664f7ae12ab078/bindings/typescript/scip.ts#L26-L64

I wonder if there is a setting we can change (or a different compatible protobuf generator we can use) to make sure that doc comments are preserved. It feels a little weird that this doesn't work out-of-the-box. 😕

varungandhi-src commented 2 years ago

Looks like this isn't implemented yet, they're looking for someone to help with implementation. https://github.com/thesayyn/protoc-gen-ts/issues/118

varungandhi-src commented 1 week ago

Related: #253