Shorten label: s/Inline discussions/Discussions

sourcegraph / sourcegraph-code-discussions

Sourcegraph Code Discussions — discuss code contextually, review code continuously.

https://sourcegraph.com/extensions/sourcegraph/code-discussions

MIT License

8 stars 6 forks source link

Shorten label: s/Inline discussions/Discussions #11

Closed attfarhan closed 5 years ago

attfarhan commented 5 years ago

Part of https://github.com/sourcegraph/sourcegraph/issues/1178.

Updates the label to be just a chat bubble icon, rather than "Inline discussions".

Also adds the parcel serve and build scripts like the new extensions have.

Screenshots: GitHub:

Sourcegraph: Light theme:

Dark theme:

attfarhan commented 5 years ago

@francisschmaltz do you know how theming works for icons contributed by extensions? couldn't figure out how to get two different colors there for light/dark theme, and not aware of any extension that uses icons in this way. (cc @sqs in case you know how this works).

Any suggestions on how to get around this otherwise?

francisschmaltz commented 5 years ago

@attfarhan can you add current screenshots

attfarhan commented 5 years ago

@francisschmaltz those in the issue description are the latest screenshots. As we discussed I didn't use the CSS hack, hence why I haven't merged.

attfarhan commented 5 years ago

@francisschmaltz I made the icon have color #808080. Updated the screenshots.

attfarhan commented 5 years ago

Updated this to just say "Discussions" instead of "Inline discussions" as per https://github.com/sourcegraph/sourcegraph/issues/1178#issuecomment-453588982.