search

sourcegraph / sourcegraph-extension-api

Sourcegraph extension API: use and build extensions that enhance reading and reviewing code in your existing tools. "The extension API you wish your code host had."
44 stars 2 forks source link

fix: error emitted from a hover provider broke other hover providers #117

Closed attfarhan closed 5 years ago

attfarhan commented 5 years ago

Fixes https://github.com/sourcegraph/sourcegraph-extension-api/issues/105

Errors from hover providers will be logged in the console, but not emitted from getHover. Now, other hover providers will continue to work if one hover provider is emitting errors. However, this means that errors won't appear in the hover tooltip when they do occur.

This PR updates the CHANGELOG.md file to describe any user-facing changes. This PR does not need to update the CHANGELOG because ...

codecov[bot] commented 5 years ago

Codecov Report

Merging #117 into master will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage   77.58%   77.62%   +0.03%     
==========================================
  Files          67       67              
  Lines        2628     2632       +4     
  Branches      534      534              
==========================================
+ Hits         2039     2043       +4     
  Misses        589      589
Impacted Files Coverage Δ
src/client/providers/hover.ts 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6126d5f...f2c6e8c. Read the comment docs.

sourcegraph-bot commented 5 years ago

:tada: This PR is included in version 18.4.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: