Closed sqs closed 6 years ago
Merging #27 into master will increase coverage by
0.02%
. The diff coverage is80%
.
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
+ Coverage 75.11% 75.13% +0.02%
==========================================
Files 93 93
Lines 3215 3222 +7
Branches 586 587 +1
==========================================
+ Hits 2415 2421 +6
- Misses 798 799 +1
Partials 2 2
Impacted Files | Coverage Δ | |
---|---|---|
src/protocol/contribution.ts | 100% <ø> (ø) |
:arrow_up: |
src/client/client.ts | 93.95% <100%> (+0.02%) |
:arrow_up: |
src/environment/controller.ts | 77.39% <75%> (+0.32%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2048ab9...1ed7e6c. Read the comment docs.
Out of curiosity, did you actually run into recursive setEnvironment calls?
Yes, when a client was stopped by setEnvironment because it was no longer needed, it would remove the context it contributed from the global context, which called setEnvironment to do so.
:tada: This PR is included in version 11.2.1 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
See commit messages.