sourcegraph / sourcegraph-git-extras

A Sourcegraph extension that adds Git blame and other useful features to code views on Sourcegraph, GitHub, GitLab, etc.
https://sourcegraph.com/extensions/sourcegraph/git-extras
MIT License
19 stars 8 forks source link

Incorrect hostname in commit link when using inline git blame functionality #85

Open zhuli19901106 opened 4 years ago

zhuli19901106 commented 4 years ago

Hi, I'm a software engineer from 4Paradigm, also a user of Sourcegraph.

I appreciate your wonderful product very much, which really helps me with code analysis.

I'd like to report a minor bug here.

As specified in the title, the URL always points to 127.0.0.1, while it's supposed to be the same hostname where it's deployed.

Setup info:

Inline commit message is correct, but generated URL points to 127.0.0.1:7080 instead of xxx (the host where I deployed it).

Fazich commented 4 years ago

I have the same problem

zhuli19901106 commented 4 years ago

Well, I've spent 5 minutes to check the code and found this: image

Since I ran Sourcegraph from within docker, no wonder the hostname is 127.0.0.1.

I've never written typescript though, maybe I'll put in a fix later.