search

sourcegraph / sourcegraph-go

Provides code intelligence for Go
6 stars 5 forks source link

Show an error notification when misconfigured #79

Open chrismwendt opened 5 years ago

chrismwendt commented 5 years ago

When your go.serverUrl is wrong, you'll see:

image

When your go.sourcegraphUrl is wrong, you'll see:

image

@ryan-blunden Any feedback on this second error message?

The icon links to https://sourcegraph.com/extensions/sourcegraph/go

image

Only admins see these error notifications.

cc @ryan-blunden who wordsmithed the first error message

felixfbecker commented 5 years ago

This looks like yet another thing that we should have for all language extensions/servers, not just Go. It should be added to lsp-client

chrismwendt commented 5 years ago

Thanks for the useful feedback 🙇

If we can get lsp-client integrated soon, I'll migrate this PR to lsp-client and then simply bump the version in sourcegraph-go.