sourcegraph / sourcegraph-go

Provides code intelligence for Go
6 stars 5 forks source link

Add icon #93

Closed chrismwendt closed 5 years ago

chrismwendt commented 5 years ago

Similar to https://github.com/sourcegraph/sourcegraph-typescript/pull/230

felixfbecker commented 5 years ago

Does this need to be square?

chrismwendt commented 5 years ago

Heh, yup

image

felixfbecker commented 5 years ago

Perhaps the webapp CSS should also be fixed so this can't happen

chrismwendt commented 5 years ago

:+1: changing webapp CSS in https://github.com/sourcegraph/sourcegraph/pull/5161

chrismwendt commented 5 years ago

Squared up the icon so it doesn't look stretched between now and when https://github.com/sourcegraph/sourcegraph/pull/5161 is merged.

convert -background none -gravity center icon.png -resize 256x256 -extent 256x256 result.png

I'll also make sure other icons I add are square because customer instances don't have https://github.com/sourcegraph/sourcegraph/pull/5161 yet.

felixfbecker commented 5 years ago

Good thinking!